Replace macros with multiple elements by splitting existing text runs/paragraphs instead of replacing them #2607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
setComplexValue()can only replace macros with a single OOXML element. #2562 tries to make it supportSectionelements for inserting a batch of elements (e.g. created from HTML).This PR is a different approach with a separate method
setElementsValue()which receives an array of elements and tries to split the paragraph or text element containing the macro variable instead of replacing it. No new paragraph is added if the replacement is inline-only (Textelements without aTextRun).Checklist:
composer run-script check --timeout=0and no errors were reported